Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra arguments for each k8sd service #485

Merged
merged 6 commits into from
Jun 13, 2024
Merged

Conversation

bschimke95
Copy link
Contributor

@bschimke95 bschimke95 commented Jun 11, 2024

Provide a way to pass to provide arbitrary extra arguments to each k8sd service. Those parameters are applied on a node-level and not shared across the cluster.

We want to support power users to supply custom configuration to the individual services, to allow management of setups like setting up kube-apiserver for encryption at rest, kubelet topology configuration, etc.

Also, adds ExtraNodeConfigFiles to load config files to /var/snap/k8s/common/args/conf.d.

@bschimke95 bschimke95 requested a review from a team as a code owner June 11, 2024 11:31
@bschimke95 bschimke95 changed the title Add extra arguments for each service Add extra arguments for each k8sd service Jun 11, 2024
@bschimke95 bschimke95 force-pushed the KU-992/node-config branch from 93d2a36 to a1c04d3 Compare June 12, 2024 14:17
src/k8s/pkg/k8sd/setup/util_extra_files.go Outdated Show resolved Hide resolved
src/k8s/pkg/snap/util/services.go Show resolved Hide resolved
tests/integration/tests/test_smoke.py Show resolved Hide resolved
tests/integration/tests/test_util/util.py Outdated Show resolved Hide resolved
@bschimke95 bschimke95 force-pushed the KU-992/node-config branch from 5cf91c3 to 401ecfc Compare June 13, 2024 09:06
Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the docs reference accordingly

tests/integration/tests/test_smoke.py Show resolved Hide resolved
@bschimke95 bschimke95 force-pushed the KU-992/node-config branch from 401ecfc to bbc707b Compare June 13, 2024 10:10
@bschimke95 bschimke95 force-pushed the KU-992/node-config branch from 3b01fd9 to a3426b8 Compare June 13, 2024 10:31
Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final nit

docs/src/snap/reference/bootstrap-config-reference.md Outdated Show resolved Hide resolved
@bschimke95 bschimke95 merged commit ee01731 into main Jun 13, 2024
11 checks passed
@bschimke95 bschimke95 deleted the KU-992/node-config branch June 13, 2024 13:06
eaudetcobello pushed a commit that referenced this pull request Jun 17, 2024
Provide a way to pass to provide arbitrary extra arguments to each k8sd service. Those parameters are applied on a node-level and not shared across the cluster.

We want to support power users to supply custom configuration to the individual services, to allow management of setups like setting up kube-apiserver for encryption at rest, kubelet topology configuration, etc.

Also, adds ExtraNodeConfigFiles to load config files to /var/snap/k8s/common/args/conf.d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants