-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra arguments for each k8sd service #485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschimke95
changed the title
Add extra arguments for each service
Add extra arguments for each k8sd service
Jun 11, 2024
bschimke95
force-pushed
the
KU-992/node-config
branch
from
June 12, 2024 14:17
93d2a36
to
a1c04d3
Compare
neoaggelos
reviewed
Jun 13, 2024
bschimke95
force-pushed
the
KU-992/node-config
branch
from
June 13, 2024 09:06
5cf91c3
to
401ecfc
Compare
neoaggelos
reviewed
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the docs reference accordingly
bschimke95
force-pushed
the
KU-992/node-config
branch
from
June 13, 2024 10:10
401ecfc
to
bbc707b
Compare
bschimke95
force-pushed
the
KU-992/node-config
branch
from
June 13, 2024 10:31
3b01fd9
to
a3426b8
Compare
neoaggelos
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final nit
eaudetcobello
pushed a commit
that referenced
this pull request
Jun 17, 2024
Provide a way to pass to provide arbitrary extra arguments to each k8sd service. Those parameters are applied on a node-level and not shared across the cluster. We want to support power users to supply custom configuration to the individual services, to allow management of setups like setting up kube-apiserver for encryption at rest, kubelet topology configuration, etc. Also, adds ExtraNodeConfigFiles to load config files to /var/snap/k8s/common/args/conf.d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a way to pass to provide arbitrary extra arguments to each
k8sd
service. Those parameters are applied on a node-level and not shared across the cluster.We want to support power users to supply custom configuration to the individual services, to allow management of setups like setting up kube-apiserver for encryption at rest, kubelet topology configuration, etc.
Also, adds
ExtraNodeConfigFiles
to load config files to/var/snap/k8s/common/args/conf.d
.