Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.32 release docs #899

Merged
merged 5 commits into from
Dec 19, 2024
Merged

1.32 release docs #899

merged 5 commits into from
Dec 19, 2024

Conversation

nhennigan
Copy link
Contributor

@nhennigan nhennigan commented Dec 12, 2024

Release docs for 1.32

@nhennigan nhennigan marked this pull request as ready for review December 18, 2024 10:09
@nhennigan nhennigan requested a review from a team as a code owner December 18, 2024 10:09
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment

Btw, please refrain from putting the Jira ticket number in the title or description of the PR. It is an internal reference that external contributors/users cannot access.
It's fine to have it in the branch name so that Jira picks it up, though.

version: '1.31'
channel: '1.31/candidate'
version: '1.32'
channel: '1.32/stable'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we define those channels here but still need to change the channels in a bunch of places?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These {{channels}}/{{version}} cannot be included in code snippets so that is why we have the install file instead. I'm not sure if they will be used in the future.

@nhennigan nhennigan changed the title Ku 2241 1.32 docs 1.32 release docs Dec 18, 2024
Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks a lot @nhennigan! LGTM

@nhennigan nhennigan merged commit 4e03dc8 into canonical:main Dec 19, 2024
19 checks passed
HomayoonAlimohammadi pushed a commit that referenced this pull request Jan 6, 2025
* 1.32 release docs for snap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants