-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.32 release docs #899
1.32 release docs #899
Conversation
start updates for 1.32 edge release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comment
Btw, please refrain from putting the Jira ticket number in the title or description of the PR. It is an internal reference that external contributors/users cannot access.
It's fine to have it in the branch name so that Jira picks it up, though.
version: '1.31' | ||
channel: '1.31/candidate' | ||
version: '1.32' | ||
channel: '1.32/stable' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we define those channels here but still need to change the channels in a bunch of places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These {{channels}}/{{version}} cannot be included in code snippets so that is why we have the install file instead. I'm not sure if they will be used in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks a lot @nhennigan! LGTM
* 1.32 release docs for snap
Release docs for 1.32