Fix containerd-related path cleanup on failed bootstrap/join and associated test. #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aznashwan
force-pushed
the
fix-lockfile-readlink
branch
from
b551777 to
5d3f2a6
Compare
berkayoz
reviewed
Dec 18, 2024
aznashwan
force-pushed
the
fix-lockfile-readlink
branch
from
5d3f2a6 to
e1f43d6
Compare
added 2 commits
December 18, 2024 12:28
…trap/join-cluster`. Signed-off-by: Nashwan Azhari <[email protected]>
Previously, the test was inducing the `bootstrap` failure by attempting to pre-allocate the port of the kube-controller-manager. This methodology wasn't applicable on any non-LocalHarness testing setups, so the test was updated to induce the failure by pre-creating the containerd socket directory (`/run/containerd`), which should lead to the same cleanup logic being triggered. Signed-off-by: Nashwan Azhari <[email protected]>
aznashwan
force-pushed
the
fix-lockfile-readlink
branch
from
e1f43d6 to
39531c1
Compare
aznashwan
commented
Dec 20, 2024
| metrics-server: | ||
| enabled: true | ||
| extra-node-kube-apiserver-args: | ||
| --foo: bar |
There was a problem hiding this comment.
Great idea, it hadn't crossed my mind to induce the failure with incorrect args!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bootstrap/join-cluster.open_local_port()testing utility for clarity.