CI improvements #927
Merged
CI improvements #927
+117
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "inspect.sh" script currently retrieves logs from the kube-system and default namespaces, which sometimes isn't enough to identify cluster problems. We're adding a "--detailed" setting that will collect logs from all namespaces. This won't be the default since the logs may contain sensitive user information.
We're moving the Trivy and Tics test logic to separate scripts, simplifying the GH workflows and allowing these tests to be invoked locally.
petrutlucian94
force-pushed
the
lpetrut/ci-improvements
branch
from
7eeaa34 to
efce8a8
Compare
We moved those tests to separate scripts, however the workflows also run against other branches (main and release/*). We'll be able to clean up the workflows only after backporting those changes to the other branches.
petrutlucian94
force-pushed
the
lpetrut/ci-improvements
branch
from
efce8a8 to
01eecbd
Compare
|
Thanks @petrutlucian94! Adding a flag is OK with me, but is it possible to always collect info. from all namespaces? Does this pollute the inspection report too much for the majority of cases? |
bschimke95
reviewed
Jan 7, 2025
| @@ -173,6 +180,25 @@ if [ "$EUID" -ne 0 ]; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| POSITIONAL_ARGS=() | |||
| while [[ $# -gt 0 ]]; do | |||
There was a problem hiding this comment.
Bash is such a beautiful and simple language.
There were concerns about collecting sensitive user data: #892 (comment) |
* use absolute paths * use venv * fix project dir
eaudetcobello
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
movedcopied TICS and Trivy tests to separate scriptsmain,release/*). We need to backport the scripts there before being able to clean up the workflows.