Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add bootstrap config docs to CAPI #936

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

HomayoonAlimohammadi
Copy link
Contributor

Overview

This PR adds bootstrapConfig field docs to CAPI references.

  • Also updates some missing fields in the same doc.

@HomayoonAlimohammadi HomayoonAlimohammadi requested a review from a team as a code owner January 8, 2025 16:00
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HomayoonAlimohammadi
Please fix the linter issues first. The Github comments make the doc hard to read.

@HomayoonAlimohammadi HomayoonAlimohammadi force-pushed the KU-2426/capi-bootstrap-config-docs branch from f759e87 to 240b769 Compare January 9, 2025 10:44
@HomayoonAlimohammadi HomayoonAlimohammadi force-pushed the KU-2426/capi-bootstrap-config-docs branch from 240b769 to a633605 Compare January 9, 2025 10:54
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/src/capi/reference/configs.md Show resolved Hide resolved
@HomayoonAlimohammadi HomayoonAlimohammadi merged commit 7257c5d into main Jan 9, 2025
6 checks passed
@HomayoonAlimohammadi HomayoonAlimohammadi deleted the KU-2426/capi-bootstrap-config-docs branch January 9, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants