Merge pull request #13 from canonical/tweak_isr

canonical · Aug 1, 2022 · cac5c6b · cac5c6b
2 parents 99bfb0c + 4a7e668
commit cac5c6b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/kafka_config.py b/src/kafka_config.py
@@ -83,7 +83,7 @@ def default_replication_properties(self) -> List[str]:
             List of properties to be set
         """
         replication_factor = min([3, self.charm.app.planned_units()])
-        min_isr = max([1, replication_factor])
+        min_isr = max([1, replication_factor - 1])
 
         return [
             f"default.replication.factor={replication_factor}",

diff --git a/tox.ini b/tox.ini
@@ -47,7 +47,7 @@ commands =
 description = Check code against coding style standards
 deps =
     black
-    flake8
+    flake8 == 4.0.1
     flake8-docstrings
     flake8-copyright
     flake8-builtins