Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement logic to get FreeBSD ttyv device names. #343

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

madpilot78
Copy link
Contributor

In FreeBSD the virtual terminals used for Xorg are named ttyv.

Their device numbers are also base32 encoded.

Code mostly taken from swaywm/wlroots@fc6c0ca

In FreeBSD the virtual terminals used for Xorg are named ttyv.

Their device numbers are also base32 encoded.

Code mostly taken from swaywm/wlroots@fc6c0ca
@madpilot78
Copy link
Contributor Author

As an extra note, this patch is an improvement on a patch already present (and needed) the FreeBSD Ports Tree.

I'm planning to add this to the FreeBSD ports tree shortly.

freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this pull request Feb 26, 2024
Adapt code from wlroots to correctly generate ttyv device names for
numbers beyond 9.

Upstream pull request: canonical/lightdm#343

PR:		277114
Obtained from:	swaywm/wlroots@fc6c0ca (inspired by)
MFH:		2024Q1
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this pull request Feb 26, 2024
Adapt code from wlroots to correctly generate ttyv device names for
numbers beyond 9.

Upstream pull request: canonical/lightdm#343

PR:		277114
Obtained from:	swaywm/wlroots@fc6c0ca (inspired by)
MFH:		2024Q1

(cherry picked from commit c88dffc)
Copy link
Collaborator

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@robert-ancell robert-ancell merged commit c51e020 into canonical:main Mar 19, 2024
3 checks passed
@madpilot78 madpilot78 deleted the FreeBSD_ttyv_logic branch March 19, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants