Skip to content

Commit

Permalink
fix(images): proper title and variable naming fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
abuyukyi101198 committed Jan 9, 2025
1 parent 5afdddf commit 3d73c2d
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ const DeleteImages = ({
message={
<>
Are you sure you want to delete <strong>{imagesCountText}</strong>?
This will also affect connected MAAS sites.
</>
}
modelType="image"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,21 +79,19 @@ describe("DownloadImages", () => {
state,
});

const row_16_04_LTS = within(
const rowUbuntu = within(
screen.getByRole("row", { name: "16.04 LTS" })
).getAllByRole("combobox");

expect(row_16_04_LTS).toHaveLength(1);
expect(
within(row_16_04_LTS[0]).getByText("amd64, i386")
).toBeInTheDocument();
expect(rowUbuntu).toHaveLength(1);
expect(within(rowUbuntu[0]).getByText("amd64, i386")).toBeInTheDocument();

const row_centos_7 = within(
const rowOther = within(
screen.getByRole("row", { name: "centos70" })
).getAllByRole("combobox");

expect(row_centos_7).toHaveLength(1);
expect(within(row_centos_7[0]).getByText("amd64")).toBeInTheDocument();
expect(rowOther).toHaveLength(1);
expect(within(rowOther[0]).getByText("amd64")).toBeInTheDocument();
});

it("can dispatch an action to save ubuntu images", async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,10 @@ const DownloadImages: React.FC = () => {

return (
<>
<p>
Select images to be imported and kept in sync daily. Images will be
available for deploying to machines managed by MAAS.
</p>
{tooManySources && (
<Notification data-testid="too-many-sources" severity="caution">
More than one image source exists. The UI does not support updating
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,6 @@ const ImagesTableHeader = ({
</Button>
</div>
</div>
<p>
Select images to be imported and kept in sync daily. Images will be
available for deploying to machines managed by MAAS.
</p>
<hr />
</div>
);
Expand Down

0 comments on commit 3d73c2d

Please sign in to comment.