Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(zones): Change edit zones to side panel #5593

Merged
merged 4 commits into from
Jan 24, 2025
Merged

feat(zones): Change edit zones to side panel #5593

merged 4 commits into from
Jan 24, 2025

Conversation

abuyukyi101198
Copy link
Contributor

@abuyukyi101198 abuyukyi101198 commented Jan 24, 2025 •
edited by ndv99
Loading

Done

  • Converted the "Edit AZ" form to a side panel form
  • Added a table action for editing AZs, connected to "Edit AZ" form
  • Removed the ZoneDetails view
  • Replaced the links to the ZoneDetails view with ZoneList

QA steps

  • Ensure there are "Edit" action buttons in the AZ table rows
  • Verify clicking the edit action button opens a side panel form titled "Edit AZ", with the fields filled automatically
  • Verify the name column entries in the AZ table are no longer links
  • Ensure the AZ names in the Machine view table redirects to the AZ view
  • Verify the url zones/{id} does not exist in the app
  • Confirm the update form works as expected, and refreshes the table

Fixes

Resolves:

MAASENG-4307
MAASENG-3408

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@abuyukyi101198 abuyukyi101198 requested a review from ndv99 January 24, 2025 14:43
ndv99
ndv99 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, optional change in diff comments below 👍

src/app/zones/views/ZonesList/ZonesListTable/AddZone/AddZone.test.tsx Outdated Show resolved Hide resolved
@abuyukyi101198 abuyukyi101198 merged commit 3888452 into canonical:main Jan 24, 2025
8 checks passed
@abuyukyi101198 abuyukyi101198 deleted the feat-change-edit-zones-to-side-panel-MAASENG-4307 branch January 24, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndv99 ndv99 ndv99 approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abuyukyi101198 @webteam-app @ndv99