Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores: add nginx to maubot #10

Merged
merged 5 commits into from
Sep 24, 2024
Merged

chores: add nginx to maubot #10

merged 5 commits into from
Sep 24, 2024

Conversation

amandahla
Copy link
Contributor

@amandahla amandahla commented Sep 19, 2024

Applicable spec:

Overview

Move NGINX to Maubot as suggested in #9 by @weiiwang01

Also remove handling exception raised by Pebble, leaving them to raise as Juju errors. The charm handle only exceptions if the user can take action. Catched it here by @Thanhphan1147

Rationale

Use only one container for Maubot.

Juju Events Changes

Module Changes

Library Changes

Checklist

maubot_rock/rockcraft.yaml Outdated Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
Copy link

Test coverage for e9cd8dd

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py      70      4      8      1    94%   101, 105, 114, 136
----------------------------------------------------------
TOTAL             70      4      8      1    94%

Static code analysis report

Run started:2024-09-23 14:12:02.369560

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 288
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@amandahla amandahla mentioned this pull request Sep 23, 2024
6 tasks
@amandahla amandahla merged commit 947ea7a into main Sep 24, 2024
17 checks passed
@amandahla amandahla deleted the add-nginx-to-maubot branch September 24, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants