-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Ingress integration #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I was going to suggest to extract a "reconcile" function, but I see that it is ready in another PR!.
Just a small comment. I approved anyway , as I see that it is also tackled in the other PR.
Test coverage for dd3c6a2
Static code analysis report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, have a suggestion for testing
Applicable spec:
Overview
Add Ingress integration to Maubot charm.
Rationale
Allow external access.
Juju Events Changes
ingress ready
ingress revoked
Module Changes
Library Changes
Add charms.traefik_k8s.v2.ingress
Checklist
src-docs
urgent
,trivial
,complex
)No CH available yet.