Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Ingress integration #8

Merged
merged 3 commits into from
Sep 17, 2024
Merged

feat: add Ingress integration #8

merged 3 commits into from
Sep 17, 2024

Conversation

amandahla
Copy link
Collaborator

Applicable spec:

Overview

Add Ingress integration to Maubot charm.

Rationale

Allow external access.

Juju Events Changes

ingress ready
ingress revoked

Module Changes

Library Changes

Add charms.traefik_k8s.v2.ingress

Checklist

No CH available yet.

@amandahla amandahla changed the title feat: add ingress integration feat: add Ingress integration Sep 11, 2024
Copy link

@javierdelapuente javierdelapuente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I was going to suggest to extract a "reconcile" function, but I see that it is ready in another PR!.

Just a small comment. I approved anyway , as I see that it is also tackled in the other PR.

src/charm.py Outdated Show resolved Hide resolved
Copy link

Test coverage for dd3c6a2

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py      47     20      8      1    51%   46, 53-59, 63-68, 72-77
----------------------------------------------------------
TOTAL             47     20      8      1    51%

Static code analysis report

Run started:2024-09-13 12:54:34.000818

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 153
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@amandahla amandahla mentioned this pull request Sep 13, 2024
6 tasks
Copy link

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have a suggestion for testing

tests/integration/test_charm.py Show resolved Hide resolved
@amandahla amandahla merged commit 6dc0117 into main Sep 17, 2024
17 checks passed
@amandahla amandahla deleted the ISD-2273-nginx branch September 17, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants