Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FIPS cgo patch #4818

Closed
wants to merge 2 commits into from
Closed

Update FIPS cgo patch #4818

wants to merge 2 commits into from

Conversation

louiseschmidtgen
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen commented Jan 10, 2025 •
edited
Loading

Update FIPS cgo patch

Patch applies successfully now:

+ git am /root/project/build-scripts/components/helm/patches/default/0002-enable-cgo.patch
Applying: enable cgo
+ bash -xe /root/project/build-scripts/components/helm/build.sh /root/parts/helm/install v3.14.4
+ VERSION=v3.14.4
+ INSTALL=/root/parts/helm/install
+ mkdir -p /root/parts/helm/install/bin
+ make VERSION=v3.14.4
GO111MODULE=on CGO_ENABLED=1 go build  -trimpath -tags '' -ldflags '-w -s -X helm.sh/helm/v3/internal/version.version=v3.14.4 -X helm.sh/helm/v3/internal/version.metadata=unreleased -X helm.sh/helm/v3/internal/version.gitCommit=66bd7bf1aff7f77fdc5b63061d7290f47cc79870 -X helm.sh/helm/v3/internal/version.gitTreeState=clean  -X helm.sh/helm/v3/pkg/lint/rules.k8sVersionMajor=1 -X helm.sh/helm/v3/pkg/lint/rules.k8sVersionMinor=29 -X helm.sh/helm/v3/pkg/chartutil.k8sVersionMajor=1 -X helm.sh/helm/v3/pkg/chartutil.k8sVersionMinor=29' -o '/root/parts/helm/build/helm/bin'/helm ./cmd/helm

Fixes: #4811

Tested builds for: helm 3.9.1 3.14.4, 1.16.3

@louiseschmidtgen louiseschmidtgen marked this pull request as ready for review January 10, 2025 13:50
@louiseschmidtgen louiseschmidtgen changed the title Update fips cgo patch Update FIPS cgo patch Jan 14, 2025
berkayoz
berkayoz approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louiseschmidtgen
update fips cgo patch
169e9c0 
add metadata

lint

helm versions
@louiseschmidtgen
Copy link
Contributor Author

This commit has been squashed into the fips branches' FIPS commit.

@louiseschmidtgen louiseschmidtgen deleted the KU-2380/fips-cgo-patch branch January 15, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkayoz berkayoz berkayoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louiseschmidtgen @berkayoz @neoaggelos