add tests for "hyper-v" and "vbox" cases

canonical · Sep 10, 2024 · 5b25bd9 · 5b25bd9
1 parent ed07c9e
commit 5b25bd9
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/src/daemon/daemon_init_settings.cpp b/src/daemon/daemon_init_settings.cpp
@@ -57,8 +57,7 @@ QString driver_interpreter(QString val)
 
     if (val == QStringLiteral("hyper-v"))
         val = QStringLiteral("hyperv");
-
-    if (val == QStringLiteral("vbox"))
+    else if (val == QStringLiteral("vbox"))
         val = QStringLiteral("virtualbox");
 
     if (!MP_PLATFORM.is_backend_supported(val))

diff --git a/tests/test_global_settings_handlers.cpp b/tests/test_global_settings_handlers.cpp
@@ -267,6 +267,32 @@ TEST_F(TestGlobalSettingsHandlers, daemonRegistersHandlerThatAcceptsValidBackend
     ASSERT_NO_THROW(handler->set(key, val));
 }
 
+TEST_F(TestGlobalSettingsHandlers, daemonRegistersHandlerThatTransformsHyperVDriver)
+{
+    auto key = mp::driver_key, val = "hyper-v";
+    auto transformed_val = "hyperv";
+
+    mp::daemon::register_global_settings_handlers();
+
+    EXPECT_CALL(*mock_qsettings, setValue(Eq(key), Eq(transformed_val)));
+    inject_mock_qsettings();
+
+    ASSERT_NO_THROW(handler->set(key, val));
+}
+
+TEST_F(TestGlobalSettingsHandlers, daemonRegistersHandlerThatTransformsVBoxDriver)
+{
+    auto key = mp::driver_key, val = "vbox";
+    auto transformed_val = "virtualbox";
+
+    mp::daemon::register_global_settings_handlers();
+
+    EXPECT_CALL(*mock_qsettings, setValue(Eq(key), Eq(transformed_val)));
+    inject_mock_qsettings();
+
+    ASSERT_NO_THROW(handler->set(key, val));
+}
+
 TEST_F(TestGlobalSettingsHandlers, daemonRegistersHandlerThatRejectsInvalidBackend)
 {
     auto key = mp::driver_key, val = "bad driver";