Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qemu] Fix crash on concurrent shutdown #3089

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

ricab
Copy link
Collaborator

@ricab ricab commented May 22, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #3089 (afb0bc0) into main (055a80f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3089   +/-   ##
=======================================
  Coverage   88.62%   88.62%           
=======================================
  Files         238      238           
  Lines       12146    12146           
=======================================
  Hits        10764    10764           
  Misses       1382     1382           
Impacted Files Coverage Δ
...rc/platform/backends/qemu/qemu_virtual_machine.cpp 68.52% <100.00%> (ø)

Copy link
Contributor

@townsend2010 townsend2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

bors merge

bors bot added a commit that referenced this pull request Jun 27, 2023
3089: [qemu] Fix crash on concurrent shutdown r=townsend2010 a=ricab



Co-authored-by: Ricardo Abreu <[email protected]>
@ricab ricab force-pushed the fix-concurrent-shutdown-crash-qemu branch from e4cdadc to afb0bc0 Compare June 27, 2023 20:01
@bors
Copy link
Contributor

bors bot commented Jun 27, 2023

Canceled.

@townsend2010
Copy link
Contributor

bors merge

bors bot added a commit that referenced this pull request Jun 28, 2023
3089: [qemu] Fix crash on concurrent shutdown r=townsend2010 a=ricab



Co-authored-by: Ricardo Abreu <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jun 28, 2023

Build failed:

@ricab
Copy link
Collaborator Author

ricab commented Jun 28, 2023

FWIW, I restarted the build that failed and it succeeded. The last missing build (win11) is running here: https://github.com/canonical/multipass/actions/runs/5397356920

@townsend2010
Copy link
Contributor

Ok, this passed the integration tests. Will merge manually.

@townsend2010 townsend2010 merged commit c334808 into main Jun 28, 2023
15 checks passed
@bors bors bot deleted the fix-concurrent-shutdown-crash-qemu branch June 28, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants