Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[snapshots] Delete snapshot cli and daemon placeholder #3092

Merged
merged 5 commits into from
Jun 27, 2023
Merged

[snapshots] Delete snapshot cli and daemon placeholder #3092

merged 5 commits into from
Jun 27, 2023

Conversation

sharder996
Copy link
Contributor

Relies on #3045

@codecov
Copy link

codecov bot commented May 23, 2023 •
edited
Loading

Codecov Report

Merging #3092 (08ee002) into snapshots (278bea7) will increase coverage by 0.12%.
The diff coverage is 61.27%.

@@              Coverage Diff              @@
##           snapshots    #3092      +/-   ##
=============================================
+ Coverage      84.71%   84.84%   +0.12%     
=============================================
  Files            241      246       +5     
  Lines          12765    13035     +270     
=============================================
+ Hits           10814    11059     +245     
- Misses          1951     1976      +25
Impacted Files Coverage Δ
include/multipass/alias_definition.h 100.00% <ø> (ø)
include/multipass/exceptions/snapshot_name_taken.h 0.00% <0.00%> (ø)
include/multipass/id_mappings.h 100.00% <ø> (ø)
include/multipass/virtual_machine.h 100.00% <ø> (ø)
src/client/cli/cmd/unalias.h 100.00% <ø> (ø)
src/daemon/daemon.h 100.00% <ø> (ø)
src/daemon/daemon_config.cpp 64.13% <0.00%> (-1.43%) ⬇️
src/daemon/daemon_rpc.cpp 87.87% <0.00%> (ø)
src/daemon/default_vm_image_vault.cpp 86.14% <ø> (ø)
...tform/backends/libvirt/libvirt_virtual_machine.cpp 62.88% <0.00%> (ø)
... and 50 more

@ricab
Copy link
Collaborator

ricab commented Jun 13, 2023 •
edited
Loading

Hey @sharder996, it looks like there is a conflict 👇 Could you please rebase?

ricab
ricab requested changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sharder996, here is a first pass with a few requests. I have yet to test, but the code looks sane.

src/client/cli/cmd/delete.cpp Outdated Show resolved Hide resolved
src/client/cli/cmd/delete.cpp Outdated Show resolved Hide resolved
src/client/cli/cmd/delete.cpp Outdated Show resolved Hide resolved
src/daemon/daemon.cpp Outdated Show resolved Hide resolved
@ricab ricab mentioned this pull request Jun 14, 2023
Merged
ricab
ricab approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, LGTM. Thanks!

@ricab ricab merged commit 7bfe04d into snapshots Jun 27, 2023
11 of 13 checks passed
@bors bors bot deleted the delete-snapshot-cli branch June 27, 2023 18:04
ricab added a commit that referenced this pull request Aug 29, 2023
@ricab
Merge pull request #3092 from canonical/delete-snapshot-cli
709ed4b 
[snapshots] Delete snapshot cli and daemon placeholder
ricab added a commit that referenced this pull request Oct 25, 2023
@ricab
Merge pull request #3092 from canonical/delete-snapshot-cli
5f3384d 
[snapshots] Delete snapshot cli and daemon placeholder
ricab added a commit that referenced this pull request Oct 30, 2023
@ricab
Merge pull request #3092 from canonical/delete-snapshot-cli
b00352e 
[snapshots] Delete snapshot cli and daemon placeholder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricab ricab ricab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharder996 @ricab