Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snapshots] Implement QEMU-specific part of snapshot deletion #3134

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

ricab
Copy link
Collaborator

@ricab ricab commented Jun 19, 2023

No description provided.

@ricab ricab requested a review from sharder996 June 19, 2023 22:04
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #3134 (92ab1f3) into delete-snapshot-daemon (ab60589) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@                    Coverage Diff                     @@
##           delete-snapshot-daemon    #3134      +/-   ##
==========================================================
- Coverage                   84.23%   84.21%   -0.02%     
==========================================================
  Files                         246      246              
  Lines                       13149    13152       +3     
==========================================================
  Hits                        11076    11076              
- Misses                       2073     2076       +3     
Impacted Files Coverage Δ
src/platform/backends/qemu/qemu_snapshot.cpp 3.03% <0.00%> (-0.31%) ⬇️

Copy link
Contributor

@sharder996 sharder996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested on Linux and macOS and is working as expected.

Base automatically changed from delete-snapshot-daemon to snapshots June 28, 2023 10:38
@ricab ricab merged commit 8a7ef72 into snapshots Jun 28, 2023
10 of 13 checks passed
@bors bors bot deleted the delete-snapshot-qemu branch June 28, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants