Dart grpc client #3144
Merged
Dart grpc client #3144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## desktop-gui #3144 +/- ##
============================================
Coverage 88.48% 88.48%
============================================
Files 239 239
Lines 12107 12107
============================================
Hits 10713 10713
Misses 1394 1394 |
andrei-toterman
force-pushed
the
dart-grpc-client
branch
from
ce421e3
to
815b774
Compare
andrei-toterman
force-pushed
the
dart-grpc-client
branch
from
815b774
to
ce14db3
Compare
andrei-toterman
force-pushed
the
dart-grpc-client
branch
from
ce14db3
to
c29f7ed
Compare
luis4a0
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Hey @andrei-toterman, LGTM. Thanks!
Same as the other associated PR's, I approve them now and merge only after rebasing.
There was a problem hiding this comment.
Very clean and tidy implementation.
andrei-toterman
force-pushed
the
dart-ffi
branch
from
495fe6d
to
3129ce4
Compare
andrei-toterman
force-pushed
the
dart-grpc-client
branch
from
c29f7ed
to
8a7ebf5
Compare
andrei-toterman
force-pushed
the
dart-ffi
branch
from
3129ce4
to
e13e1a9
Compare
andrei-toterman
force-pushed
the
dart-grpc-client
branch
from
8a7ebf5
to
facb1c2
Compare
andrei-toterman
force-pushed
the
dart-ffi
branch
from
e13e1a9
to
4dcb44b
Compare
andrei-toterman
force-pushed
the
dart-grpc-client
branch
from
facb1c2
to
73905e9
Compare
andrei-toterman
force-pushed
the
dart-ffi
branch
from
4dcb44b
to
9772b55
Compare
andrei-toterman
force-pushed
the
dart-grpc-client
branch
from
73905e9
to
33d1867
Compare
andrei-toterman
force-pushed
the
dart-ffi
branch
from
9772b55
to
083e979
Compare
andrei-toterman
force-pushed
the
dart-grpc-client
branch
from
33d1867
to
58319e8
Compare
andrei-toterman
force-pushed
the
dart-ffi
branch
from
083e979
to
105e419
Compare
andrei-toterman
force-pushed
the
dart-grpc-client
branch
from
58319e8
to
713b7eb
Compare
andrei-toterman
force-pushed
the
dart-ffi
branch
from
105e419
to
04e4e06
Compare
andrei-toterman
force-pushed
the
dart-grpc-client
branch
from
713b7eb
to
6468fe8
Compare
andrei-toterman
force-pushed
the
dart-ffi
branch
from
04e4e06
to
bae61eb
Compare
andrei-toterman
force-pushed
the
dart-grpc-client
branch
from
6468fe8
to
93a12fe
Compare
andrei-toterman
force-pushed
the
dart-grpc-client
branch
from
93a12fe
to
861888c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a wrapper for the grpc client and several useful data providers, as well as displaying some rudimentary instance information on the main page, just to make sure it works.