Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snapshots] Snapshot and update QEMU mount args #3151

Closed
wants to merge 2 commits into from

Conversation

ricab
Copy link
Collaborator

@ricab ricab commented Jul 4, 2023

Keep reference to mount args in snapshot and update when applying. I am still not sure if this is necessary, since the QemuMountHandler updates the mount args upon construction and destruction.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #3151 (ab0a8a9) into fix-qemu-restore (efa7342) will decrease coverage by 0.04%.
The diff coverage is 21.73%.

@@                 Coverage Diff                  @@
##           fix-qemu-restore    #3151      +/-   ##
====================================================
- Coverage             84.89%   84.86%   -0.04%     
====================================================
  Files                   246      246              
  Lines                 13001    13006       +5     
====================================================
  Hits                  11037    11037              
- Misses                 1964     1969       +5     
Impacted Files Coverage Δ
src/platform/backends/qemu/qemu_snapshot.cpp 2.32% <0.00%> (-0.31%) ⬇️
src/platform/backends/qemu/qemu_virtual_machine.h 100.00% <ø> (ø)
...rc/platform/backends/qemu/qemu_virtual_machine.cpp 66.88% <35.71%> (ø)

@ricab ricab force-pushed the qemu-snapshot-mount-args branch from 1ca344e to ab0a8a9 Compare July 4, 2023 20:02
@ricab
Copy link
Collaborator Author

ricab commented Jul 5, 2023

I couldn't find a use case that needed this after all. If we restored snapshots on suspended instances, we would need this because. But we don't, so closing until we find some other reason.

@ricab ricab closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant