Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3rd-party] Update gRPC branch #3154

Merged
merged 1 commit into from
Jul 10, 2023
Merged

[3rd-party] Update gRPC branch #3154

merged 1 commit into from
Jul 10, 2023

Conversation

townsend2010
Copy link
Contributor

@townsend2010 townsend2010 commented Jul 10, 2023

There is a regression seen on macOS in the latest gRPC branch we used for the 1.12 release. The gRPC branch has been updated to revert the problematic commits.

Fixes #3142


Here are the relevant changes in our gRPC branch: canonical/grpc@e796379 and canonical/grpc@e3acf24.

There is a regression seen on macOS in the latest gRPC branch we used
for the 1.12 release.  The gRPC branch has been updated to revert the
problematic commits.

Fixes #3142
Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! My only request would be that this be followed up upstream, but you already said you'd do so.

bors r+

bors bot added a commit that referenced this pull request Jul 10, 2023
3154: [3rd-party] Update gRPC branch r=ricab a=townsend2010

There is a regression seen on macOS in the latest gRPC branch we used for the 1.12 release.  The gRPC branch has been updated to revert the problematic commits.

Fixes #3142



Co-authored-by: Chris Townsend <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 10, 2023

Build failed:

@townsend2010
Copy link
Contributor Author

Something weird is happening with Windows integration tests, but after manually restarting those, it worked: https://github.com/canonical/multipass/actions/runs/5512166684/jobs/10049173820

@townsend2010 townsend2010 merged commit 91ce5df into main Jul 10, 2023
13 checks passed
@bors bors bot deleted the fix-grpc-regression branch July 10, 2023 20:24
townsend2010 added a commit that referenced this pull request Jul 11, 2023
3154: [3rd-party] Update gRPC branch r=ricab a=townsend2010

There is a regression seen on macOS in the latest gRPC branch we used for the 1.12 release.  The gRPC branch has been updated to revert the problematic commits.

Fixes #3142



Co-authored-by: Chris Townsend <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[regression][macos] Restarting daemon while tray GUI is running can hang the daemon
2 participants