[snapshots] Fix QEMU backend refusing available snapshot names #3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When looking for existing snapshot names, look for whitespace-terminated names only, to avoid matching on prefixes.
Avoid intermediate strings when looking for existing snapshot names.
sharder996
requested changes
Jul 11, 2023
There was a problem hiding this comment.
Actually, there seems to be a few tests that are failing now
[ FAILED ] 3 tests, listed below:
[ FAILED ] QemuBackend.verify_qemu_arguments_when_resuming_suspend_image
[ FAILED ] QemuBackend.verify_qemu_arguments_when_resuming_suspend_image_uses_metadata
[ FAILED ] QemuBackend.verify_qemu_arguments_from_metadata_are_used
|
Yeah, I noticed that too. I will look into it tomorrow. |
Fix failing tests by adapting to the QEMU backend now expecting the snapshot tag column to end in whitespace.
Codecov Report
@@ Coverage Diff @@
## snapshots #3158 +/- ##
=============================================
- Coverage 85.07% 84.88% -0.20%
=============================================
Files 246 246
Lines 12978 13016 +38
=============================================
+ Hits 11041 11048 +7
- Misses 1937 1968 +31
|
|
It should be good now @sharder996. |
sharder996
approved these changes
Jul 12, 2023
ricab
pushed a commit
that referenced
this pull request
Aug 29, 2023
[snapshots] Fix QEMU backend refusing available snapshot names
ricab
pushed a commit
that referenced
this pull request
Oct 25, 2023
[snapshots] Fix QEMU backend refusing available snapshot names
ricab
pushed a commit
that referenced
this pull request
Oct 30, 2023
[snapshots] Fix QEMU backend refusing available snapshot names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix QEMU backend refusing available snapshot names that are also prefixes in existing snapshot names.