Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the uptime checking isnull #3611

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Improve the uptime checking isnull #3611

merged 2 commits into from
Jul 31, 2024

Conversation

georgeliao
Copy link
Contributor

No description provided.

ricab
ricab approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeating review from #3574 (which GH messed up somehow).

@andrei-toterman andrei-toterman added this pull request to the merge queue Jul 30, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.99%. Comparing base (2bebce6) to head (701cc21).
Report is 23 commits behind head on main.

Files Patch % Lines
src/daemon/runtime_instance_info_helper.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3611      +/-   ##
==========================================
+ Coverage   88.89%   88.99%   +0.10%     
==========================================
  Files         254      254              
  Lines       14222    14360     +138     
==========================================
+ Hits        12642    12780     +138     
  Misses       1580     1580

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 30, 2024
@ricab ricab enabled auto-merge July 30, 2024 18:13
@ricab ricab disabled auto-merge July 30, 2024 18:13
@ricab ricab marked this pull request as draft July 30, 2024 18:13
@ricab ricab marked this pull request as ready for review July 30, 2024 18:14
@ricab ricab enabled auto-merge July 30, 2024 18:14
@ricab ricab added this pull request to the merge queue Jul 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2024
@ricab ricab added this pull request to the merge queue Jul 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 31, 2024
@ricab
Copy link
Collaborator

ricab commented Jul 31, 2024

Oh for crying out loud 😭

@ricab ricab added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit 9d7e41d Jul 31, 2024
31 of 33 checks passed
@ricab ricab deleted the improve_the_uptime_checking_isnull branch July 31, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrei-toterman andrei-toterman andrei-toterman approved these changes

@ricab ricab ricab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgeliao @ricab @andrei-toterman