Update README.md #3630
Merged
Update README.md #3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I reviewed the README text, applying some layout improvements and minor copy edits. I also added a new section, "Contributing guidelines", please provide feedback on that! Signed-off-by: Giulia Zanchi <[email protected]>
giuliazanchi
requested review from
georgeliao,
ricab,
andrei-toterman and
sharder996
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3630 +/- ##
=======================================
Coverage 88.88% 88.88%
=======================================
Files 254 254
Lines 14225 14225
=======================================
Hits 12644 12644
Misses 1581 1581 ☔ View full report in Codecov by Sentry. |
sharder996
requested changes
Aug 8, 2024
georgeliao
reviewed
Aug 8, 2024
georgeliao
reviewed
Aug 8, 2024
georgeliao
reviewed
Aug 8, 2024
I've applied all the fixes suggested by the team (thanks Andrei, Jia and Scott!). Please review and see if it's all good now. I have also been testing the instructions to Multipass, they need some debugging. For now I'll leave the contributing info as a subsection of the Readme, but let's consider the possibility of having it as a separate file as it's done on other projects. Signed-off-by: Giulia Zanchi <[email protected]>
|
@andrei-toterman @georgeliao @sharder996 please review the latest fixes and approve if it looks good now! I'll keep working on the "build Multipass" instructions and create a separate PR if needed. |
andrei-toterman
previously approved these changes
Aug 12, 2024
georgeliao
reviewed
Aug 12, 2024
georgeliao
reviewed
Aug 12, 2024
README.md
Outdated
| Description: Ubuntu 18.04.1 LTS | ||
| Release: 18.04 | ||
| Codename: bionic | ||
| Distributor ID: Ubuntu |
There was a problem hiding this comment.
can we make the 2nd column left aligned like the text before?
There was a problem hiding this comment.
OK I checked the alignment, please see if it looks correct now.
Removed secondary IP address from "dancing-chipmunk" in the first example output of `multipass list`. Signed-off-by: Giulia Zanchi <[email protected]>
Removed secondary IP from "dancing-chipmunk" in the output of `multipass info`. Signed-off-by: Giulia Zanchi <[email protected]>
Fixed space alignment Signed-off-by: Giulia Zanchi <[email protected]>
sharder996
requested changes
Aug 12, 2024
Co-authored-by: ScottH <[email protected]> Signed-off-by: Giulia Zanchi <[email protected]>
georgeliao
approved these changes
Aug 13, 2024
|
Merging this since both Jia and Scott approved the changes :) |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reviewed the README text, applying some layout improvements and minor copy edits.
I also added a new section, "Contributing guidelines", please provide feedback on that!