clarify behavior of multipass shell in short_help and description
#3649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @giuliazanchi, how does this change look to you? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3649 +/- ##
=======================================
Coverage 88.88% 88.88%
=======================================
Files 254 254
Lines 14250 14251 +1
=======================================
+ Hits 12666 12667 +1
Misses 1584 1584 ☔ View full report in Codecov by Sentry. |
giuliazanchi
requested changes
Aug 29, 2024
There was a problem hiding this comment.
Nice improvements, @levkropp ! I've suggested a couple of minor changes.
giuliazanchi
previously approved these changes
Aug 29, 2024
levkropp
force-pushed
the
clarify-shell-cmd-short-help
branch
2 times, most recently
from
0f9cedf
to
e21f6a8
Compare
levkropp
force-pushed
the
clarify-shell-cmd-short-help
branch
from
e21f6a8
to
1180489
Compare
Co-authored-by: Giulia Zanchi <[email protected]> Signed-off-by: levkropp <[email protected]>
levkropp
force-pushed
the
clarify-shell-cmd-short-help
branch
from
1180489
to
3ecba40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1133