change window minimumSize to 750x450, and default size based on screen resolution

[levkropp]

close #3590

We can use the window_size flutter plugin from google's flutter desktop embeddings repository https://github.com/google/flutter-desktop-embedding/tree/main/plugins/window_size
to check the size of the screen, and

• if the size of the screen is below 1600x900, open a small 750x450 window
• if the size of the screen is larger then open the 1400x822 window that multipass is currently set to by default. We can also think of more reactive functionality than this but I don't think it's necessary.

We'll need to add this plugin to pubspec.yaml, but it's an official plugin from Google the closest-to-official Flutter plugin that handles screen size and it seems that the only reason that this plugin needs to be added at all is because Google has not yet added this functionality to the Flutter framework itself

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (eca4986) to head (42ce182).
Report is 74 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3663      +/-   ##
==========================================
- Coverage   88.88%   88.86%   -0.03%     
==========================================
  Files         254      254              
  Lines       14256    14269      +13     
==========================================
+ Hits        12672    12680       +8     
- Misses       1584     1589       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ricab]

LGTM, modulo the inline suggestion.

[ricab]

Resolutions tend to stick to round numbers, so maybe use >=.

[andrei-toterman]

Why is this removing the logger setup?

Also, since we only care about the screen size, not the entire screen object, you could do something like

final screenSize = await getCurrentScreen().then((screen) {
    return screen?.frame.size;
});

so that you don't have to do the .frame.size thing multiple times

[andrei-toterman]

Why is this removing the initialization of the window manager?

Also, you could make windowSize final and initialize it with a ternary operator instead of the if-else.

[andrei-toterman]

Hey, @levkropp! It looks much better now. But I noticed something is missing. You added a plugin, which also modified the plugin registry files for each platform. And those changes must also be committed.

So you'll have to do something like this in the src/client/gui directory:

flutter config --enable-macos-desktop --enable-windows-desktop
flutter pub get

This should modify some files inside the linux, macos and windows directories related to registered plugins. Please commit those as well.

If you don't already have flutter in your PATH, you can add the multipass/3rd-party/flutter/bin directory to your path. (And by this I mean of course the entire path of that directory)

[andrei-toterman]

Alright, LGTM. Thanks, @levkropp!