Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small qemu improvements #3681

Merged
merged 3 commits into from
Sep 20, 2024
Merged

small qemu improvements #3681

merged 3 commits into from
Sep 20, 2024

Conversation

sharder996
Copy link
Contributor

Small cleanup:

  • Moved common stub monitor to test_qemu_backend constructor
  • Some tests were using a mock object but were not mocking function calls, so replaced with stub object
  • Removed a couple instance variables from the qemu virtual machine class as they are simply copies of members from the already saved VirtualMachineDescription

Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Feel free to merge if/when it passes CI.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.85%. Comparing base (5f4dfe2) to head (daddd3d).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...rc/platform/backends/qemu/qemu_virtual_machine.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3681      +/-   ##
==========================================
- Coverage   88.85%   88.85%   -0.01%     
==========================================
  Files         254      254              
  Lines       14269    14267       -2     
==========================================
- Hits        12679    12677       -2     
  Misses       1590     1590              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sharder996 sharder996 added this pull request to the merge queue Sep 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 20, 2024
@sharder996 sharder996 added this pull request to the merge queue Sep 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 20, 2024
@sharder996 sharder996 added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 533e02f Sep 20, 2024
13 of 14 checks passed
@sharder996 sharder996 deleted the qemu-improvements branch September 20, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants