Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Update GHA to only cancel for merge queues #3694

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

Sploder12
Copy link
Contributor

No description provided.

Copy link
Contributor

@sharder996 sharder996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If GitHub Actions only cancel in merge queues, I'm wondering why several Actions were cancelled for the run generated by this PR 🤔

https://github.com/canonical/multipass/actions/runs/11020341482/job/30604920256

The job was canceled because "Coverage" failed.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.93%. Comparing base (a8725ac) to head (a189df4).
Report is 48 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3694      +/-   ##
==========================================
- Coverage   88.93%   88.93%   -0.01%     
==========================================
  Files         254      254              
  Lines       14269    14294      +25     
==========================================
+ Hits        12690    12712      +22     
- Misses       1579     1582       +3     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sharder996 sharder996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think this looks good now

Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sharder996 sharder996 added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024
@sharder996 sharder996 added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 521a43e Oct 10, 2024
14 checks passed
@sharder996 sharder996 deleted the update-actions-cancel-behavior branch October 10, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants