-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libssh to 0.11.1 #3735
base: main
Are you sure you want to change the base?
Update libssh to 0.11.1 #3735
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3735 +/- ##
==========================================
- Coverage 88.93% 88.80% -0.14%
==========================================
Files 254 255 +1
Lines 14299 14569 +270
==========================================
+ Hits 12717 12938 +221
- Misses 1582 1631 +49 ☔ View full report in Codecov by Sentry. |
da5d0fc
to
79996f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work Trevor, thanks. I ask only for some unit tests for the new code. Other than that, +1 on my secondary review.
Some reproduction steps for the issues. Formatting:
Mounts:
|
Sets the timeout to infinite since no messages for extended periods of time is expected behavior. Libssh updated to fix timeout being ignored.
Sets the pty mode explicitly to default since Libssh updated to inherit settings from
stdin
.Fixes #3745