Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli/launch] remove default mount target from --mount #3756

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrei-toterman
Copy link
Contributor

The default mount target is now chosen by the daemon.

@andrei-toterman andrei-toterman force-pushed the remove-default-mount-target-from-launch branch from d3da39d to 0fb31b4 Compare October 24, 2024 18:55
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (abe0391) to head (0fb31b4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3756   +/-   ##
=======================================
  Coverage   88.85%   88.86%           
=======================================
  Files         256      256           
  Lines       14557    14556    -1     
=======================================
  Hits        12935    12935           
+ Misses       1622     1621    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sharder996 sharder996 added this to the 1.15.0 milestone Oct 30, 2024
@andrei-toterman andrei-toterman self-assigned this Oct 30, 2024
Copy link
Contributor

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants