DPE-5178 Admin address #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomach
requested review from
shayancanonical,
taurus-forever and
carlcsaposs-canonical
carlcsaposs-canonical
approved these changes
Sep 12, 2024
taurus-forever
approved these changes
Sep 12, 2024
| f"result = session.run_sql(\"SHOW VARIABLES LIKE '{variable}'\")", | ||
| "print(result.fetch_all())", | ||
| ] | ||
|
|
||
| try: | ||
| output = self._run_mysqlsh_script("\n".join(get_var_command)) | ||
| except MySQLClientError: | ||
| logger.exception(f"Failed to get variable {variable}") | ||
| logger.exception(f"Failed to get value for {variable=}") |
There was a problem hiding this comment.
will the output be useful? The value obliviously will be empty (as failed to request).
There was a problem hiding this comment.
It will. The variable will be set, the value won't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of admin_address on k8s.
VM PRs PR#516 and PR#520