Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port over charm lib changes from k8s charm relating to pod reschdule during cluster setup #518

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Port over charm lib changes from k8s charm relating to pod reschdule during cluster setup #518

merged 6 commits into from
Sep 13, 2024

Conversation

shayancanonical
Copy link
Contributor

Lib changes in canonical/mysql-k8s-operator#499 to be published to charmhub

paulomach
paulomach reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@paulomach paulomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've merged the admin_address, which will require some merge on the mysql.py. The merge should be smooth, but also it will require a change in how we build the connection string for mysqlsh calls

@taurus-forever
Copy link
Contributor

Consider LGTM from me, but you need to address Paulo comment. I am not setting LGTM on GH to avoid the merge by mistake (2xLGTM already).

paulomach
paulomach approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@paulomach paulomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

tests/unit/test_mysql.py Outdated Show resolved Hide resolved
@shayancanonical shayancanonical merged commit 14224d9 into main Sep 13, 2024
102 checks passed
@shayancanonical shayancanonical deleted the feature/pod_reschedule_recovery_libs branch September 13, 2024 13:55
@paulomach paulomach mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlcsaposs-canonical carlcsaposs-canonical carlcsaposs-canonical approved these changes

@paulomach paulomach paulomach approved these changes

@taurus-forever taurus-forever Awaiting requested review from taurus-forever

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shayancanonical @taurus-forever @paulomach @carlcsaposs-canonical