DPE-5178 Retrieve relation connection data from test-app #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomach
requested review from
carlcsaposs-canonical,
shayancanonical and
taurus-forever
carlcsaposs-canonical
approved these changes
Sep 5, 2024
| @@ -399,6 +404,19 @@ def _on_update_status(self, _) -> None: | |||
| else: | |||
| self.unit.status = WaitingStatus() | |||
|
|
|||
| def _on_get_client_connection_data(self, event: ActionEvent) -> None: | |||
There was a problem hiding this comment.
misnomer: it is partial connection data. should we also include host and port in the results?
There was a problem hiding this comment.
For completion, yes. I didn't bother since usage on tests rely on helpers for getting unit ip/addres, which might be not resolvable from outside the cluster
shayancanonical
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change related to mysql vm PR#516