Skip to content

Commit

Permalink
parse.c: quiet "may be used uninitialized" warnings/errors
Browse files Browse the repository at this point in the history
gcc complains about ip_str not being initialized before the cleanup
function is called:

    In file included from /usr/include/glib-2.0/glib.h:117,
                     from ../src/parse.c:25:
    In function ‘g_autoptr_cleanup_generic_gfree’,
        inlined from ‘get_ip_family’ at ../src/parse.c:1912:22:
    /usr/include/glib-2.0/glib/glib-autocleanups.h:32:3: error: ‘ip_str’ may be used uninitialized [-Werror=maybe-uninitialized]
       32 |   g_free (*pp);
          |   ^~~~~~~~~~~~
    ../src/parse.c: In function ‘get_ip_family’:
    ../src/parse.c:1912:22: note: ‘ip_str’ was declared here
     1912 |     g_autofree char *ip_str;
          |                      ^~~~~~
    cc1: all warnings being treated as errors

Let's initialize it to NULL to satisfy the compiler.
  • Loading branch information
drafnel authored and slyon committed Nov 12, 2024
1 parent 52b375a commit 57795b4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/parse.c
Original file line number Diff line number Diff line change
Expand Up @@ -1909,7 +1909,7 @@ handle_vxlan_tristate(NetplanParser* npp, yaml_node_t* node, const void* data, G
STATIC int
get_ip_family(const char* address)
{
g_autofree char *ip_str;
g_autofree char *ip_str = NULL;
char *prefix_len;

ip_str = g_strdup(address);
Expand Down

0 comments on commit 57795b4

Please sign in to comment.