state_diff: include the lo interface in the diff

canonical · Oct 27, 2023 · ae0a302 · ae0a302
1 parent 41aa6e3
commit ae0a302
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/netplan_cli/cli/state_diff.py b/netplan_cli/cli/state_diff.py
@@ -317,9 +317,6 @@ def _analyze_missing_interfaces(self, report: dict) -> None:
 
         system_only = []
         for iface in self.system_state.interface_list:
-            # Let's not show the loopback interface as missing
-            if iface.name == 'lo':
-                continue
             if iface.netdef_id not in netplan_interfaces:
                 system_only.append(iface.name)
 

diff --git a/tests/cli/test_state_diff.py b/tests/cli/test_state_diff.py
@@ -344,8 +344,8 @@ def test_diff_missing_netplan_interface(self):
 
         missing = diff_data.get('missing_interfaces_netplan', [])
         self.assertIn('eth0', missing)
-        # lo is filtered out
-        self.assertNotIn('lo', missing)
+        # lo is included
+        self.assertIn('lo', missing)
 
     def test_diff_missing_system_interface(self):
         with open(self.path, "w") as f: