Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: initial NetworkManager autopkgtests #374

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

slyon
Copy link
Collaborator

@slyon slyon commented Jun 28, 2023

Description

We're testing NetworkManager from mantic-proposed against a local build of netplan.io from this repository.

So far we can only run NetworkManager's autopkgtests which allow for 'isolation-container'.

FR-4415

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

We're testing NetworkManager from mantic-proposed against a local build of
netplan.io from this repository.

So far we can only run NetworkManager's autopkgtests which allow for
'isolation-container'.
@slyon slyon requested a review from daniloegea June 28, 2023 10:54
Copy link
Collaborator

@daniloegea daniloegea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine hard coding mantic there. I though of using ubuntu-daily:devel so we wouldn't need to update the yaml, but I don't know if it's safe to use it...

@slyon
Copy link
Collaborator Author

slyon commented Jun 29, 2023

I think it's fine hard coding mantic there. I though of using ubuntu-daily:devel so we wouldn't need to update the yaml, but I don't know if it's safe to use it...

Yes, that was my first attempt. But autopkgtest-build-lxd will then still create an autopkgtest/ubuntu/mantic/amd64 alias for the image, so we need to hard-code "mantic" anyway. Therefore, I decided to keep it the same in both places.

@slyon slyon merged commit 6dedb27 into canonical:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants