Addressing a few issues found by coverity #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverity IDs: 398341, 398338
Coverity ID: 398340
slyon
reviewed
Aug 14, 2023
| @@ -2097,6 +2097,7 @@ handle_routes(NetplanParser* npp, yaml_node_t* node, __unused const void* _, GEr | |||
|
|
|||
| err: | |||
| route_clear(&npp->current.route); | |||
| npp->current.route = NULL; | |||
There was a problem hiding this comment.
comment: FWIW, I think this nullification is already being done, using the CLEAR_FROM_FREE macro. But I guess it doesn't hurt to do it manually again in the error case.
There was a problem hiding this comment.
hmm yeah, that's true. Coverity (and I) wasn't smart enough to see that I guess... well, if nothing, this line will eliminate an issue from the Coverity report.
slyon
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing CIDs 398341, 398340 and 398338.
Checklist
make checksuccessfully.make check-coverage).