Handle implicity conversions #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
slyon
requested changes
Aug 20, 2024
There was a problem hiding this comment.
Thank you very much for working on this, this is tedious work!
I left a bunch of remarks inline that need clarification. Furthermore, I think we should try compiling this branch on some additional architectures (i386, armhf, s390x, maybe more from Debian buildd?) to make sure it does not trigger any side-effects of types having different size on non-64bit architectures.
This flag will make the compiler to issue a warning for all the dangerous implicit type conversions.
wifi_get_freq24 and wifi_get_freq5 are used with ap->channel values, which are guint. Change these functions to take guint as argument.
daniloegea
force-pushed
the
w_conversion_flag
branch
from
94de4cf
to
06f72a0
Compare
Here we probably should make _netplan_state_get_vf_count_for_def return a unsigned int, but as it is a public interface (even though only used inside netplan) I'll add some safety checks and cast the return value to int.
daniloegea
force-pushed
the
w_conversion_flag
branch
from
06f72a0
to
b56f5f8
Compare
|
Thanks Lukas. I think I addressed your comments. In particular, there was a problem with 32-bit. It happened on armhf. I added the compiler error to one of my replies. I created a package from this branch and tested it with autopkgtest on all the archs supported by Ubuntu and it looks good. |
slyon
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix some type conversions and make some implicit conversions explicit.
It's a requirement to add the TIOBE analysis to our CI as it will build the project with
-Wconversion.I'd recommend to use interactive rebase to step through each commit individually starting from the first one and call
meson compilewith-j1so you can see what compiler errors each commit fixes. I didn't want to paste the error to the commit messages...Checklist
make checksuccessfully.make check-coverage).