Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/tics: set the token before trying to download TICS #508

Merged
merged 1 commit into from
Aug 20, 2024
Merged

ci/tics: set the token before trying to download TICS #508

merged 1 commit into from
Aug 20, 2024

Conversation

daniloegea
Copy link
Collaborator

@daniloegea daniloegea commented Aug 20, 2024 •
edited
Loading

The download started to fail without authentication.

I tested it locally and the script install_tics.sh works when the variable is exported.

Description

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

@daniloegea
ci/tics: set the token before trying to download TICS
b3da16c 
The download started to fail without authentication.
@daniloegea daniloegea requested a review from slyon August 20, 2024 11:00
slyon
slyon approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@slyon slyon merged commit e5d58dd into canonical:main Aug 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slyon slyon slyon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniloegea @slyon