Avoid dependency on dbus-python #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python3-dbus is not in a good shape apparently: https://lists.debian.org/debian-devel/2024/07/msg00226.html Also use lazy % formatting in logging function, as suggested by pylint/TiCS: https://pylint.readthedocs.io/en/latest/user_guide/messages/warning/logging-fstring-interpolation.html Also fix ordering of imports, using isort
Also fix ordering of some imports, using isort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
call
busctl(part of system) in favour of usingdbus-pythonpython3-dbusis not in a good shape apparently:https://lists.debian.org/debian-devel/2024/07/msg00226.html
Also use lazy % formatting in logging function, as suggested by pylint/TiCS:
https://pylint.readthedocs.io/en/latest/user_guide/messages/warning/logging-fstring-interpolation.html
Fix ordering of imports, using
isortwhile touching those files, too.FR-8728
Checklist
make checksuccessfully.make check-coverage).