ovs: quote external-ids and other-config values (LP: #2070318) #512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For complex values, ovs-vsctl requires that they are quoted or it will error out. LP: #2070318
Interestingly, it seems to work from systemd units. But I added quotes there too.
I added a new test case to the integration test
test_settings_tag_cleanup
that will fail without quotes. It's based on the example provided in the bug report.While here, add some debugging information so we can see the ovs-vsctl command executed by "netplan apply" with --debug.
I created a PPA for Noble with this patch: https://launchpad.net/~danilogondolfo/+archive/ubuntu/netplan.io/
Description
Checklist
make check
successfully.make check-coverage
).