[RFC] CI: Ignore errors off by default #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daniloegea How do you feel about this? Is it necessary to have the duplicated tests run in multiple upstream CI, downstream autopkgtests and Salsa CI? Or is just a single, upstream CI test enough? |
It's taking lots of compute time in upstream and downstream CI systems. We still keep it on inside our `autopkgtest.yml` CI test, but turn it off by default otherwise.
slyon
force-pushed
the
ignore-errors-off-by-default
branch
from
1fe7a07
to
c3d3307
Compare
|
I think it's enough to have it enabled only in our Github CI for autopkgtests. Arguably it should be enough to have it only in the config-fuzzing workflow but I'd feel more comfortable with the autopkgtest too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CI:tests: Disable NETPLAN_PARSER_IGNORE_ERRORS by default
It's taking lots of compute time in upstream and downstream CI systems.
We still keep it on inside our
autopkgtest.ymlCI test, but turn it offby default otherwise.
Checklist
make checksuccessfully.make check-coverage).