Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs directory structure to reflect diátaxis #520

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

davidekete
Copy link
Contributor

@davidekete davidekete commented Sep 24, 2024

Description

Checklist

  • Runs make check successfully.
  • Retains code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

@slyon slyon added community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. documentation Documentation improvements. labels Sep 25, 2024
@rkratky
Copy link
Contributor

rkratky commented Sep 25, 2024

@davidekete, thanks for submitting this! To fix the spellcheck and one cross-doc link, I submitted a PR against your branch: davidekete#3

Fix paths to reference docs for link and spellcheck.
@davidekete
Copy link
Contributor Author

@davidekete, thanks for submitting this! To fix the spellcheck and one cross-doc link, I submitted a PR against your branch: davidekete#3

Thank you. I just merged the PR.

@rkratky
Copy link
Contributor

rkratky commented Sep 25, 2024

Two notes:

  • @davidekete, as discussed on Matrix, could you please rename the main/landing files in the individual categories to index.md? This naming convention is used in all other Ubuntu docs published on RTD, so it'd be good to keep it consistent. Also, it'd avoid the duplication that results from Sphinx building the landing page in two places when the index file is absent.
  • @slyon, while this change in directory structure is certainly an improvement for the repo, it'll mean some existing URLs would no longer work. Therefore, we need redirects. My question is: do you think it would be enough to add redirects for the main categories only (i.e. explanation, howto, ...), or do we need redirects for all existing pages?

@slyon
Copy link
Collaborator

slyon commented Sep 25, 2024

  • do we need redirects for all existing pages?

I think the most important one would be the netplan-yaml reference. Maybe that in combination with the main categories. And also making sure that our website still points to the correct reference, e.g.: https://netplan.io/reference

@slyon slyon self-requested a review September 25, 2024 14:24
@davidekete
Copy link
Contributor Author

Two notes:

  • @davidekete, as discussed on Matrix, could you please rename the main/landing files in the individual categories to index.md? This naming convention is used in all other Ubuntu docs published on RTD, so it'd be good to keep it consistent. Also, it'd avoid the duplication that results from Sphinx building the landing page in two places when the index file is absent.
  • @slyon, while this change in directory structure is certainly an improvement for the repo, it'll mean some existing URLs would no longer work. Therefore, we need redirects. My question is: do you think it would be enough to add redirects for the main categories only (i.e. explanation, howto, ...), or do we need redirects for all existing pages?

@rkratky, I have renamed them as index.md and updated the references to match the names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. documentation Documentation improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants