RFC: New "networkmanager.passthrough" structure (LP: #2080301) #522
Commits on Nov 8, 2024
-
parse: new structure for "passthrough"
The networkmanager.passthrough section stores raw keyfile information using a format that can be tricky to interpret. It will concatenate the group and key names separated by dots. Unfortunately, Network Manager accepts multiple dots in the middle of both the group and key names. Because of that it's hard, if even possible, to determine where the strings must be split. Ex: networkmanager: passthrough: group_name.key_name: value1 group_name.key_name1: value2 The new format stores the same information in YAML mappings. By using this format, parsing the group and key names is not needed anymore. Ex: networkmanager: passthrough: group_name: key_name1: value1 key_name2: value2 The datalist data structure was replaced by hash tables. The entire passthrough section is represented by a hash table indexed by the group name. Each entry is also a hash table representing all the key/value entries and it's indexed by the key name. -
-
config_fuzzer: run generate -i against the entire dataset
Now that the datalist was replaced with hash tables, run the generator with --ignore-errors against the entire dataset. The datalist was leaking memory and causing ASAN to crash the test. Also limit the value of path-cost to avoid triggering a g_assert(v < G_MACUINT).
-
tests: update config_fuzzer with new passthrough format
Now it will generate a mix of old and new formats in the passthrough section.
-
nm: fix crashes when errors are ignored
When --ignore-errors is used, some netdefs might arrive at the NM config writers in a bad state. In such cases we just skip them. Found with config_fuzzer.
-
parse: fix uninitialized variable
Fixes the build on Fedora 41: In file included from /usr/include/glib-2.0/glib.h:117, from ../src/parse.c:25: In function ‘g_autoptr_cleanup_generic_gfree’, inlined from ‘get_ip_family’ at ../src/parse.c:1918:22: /usr/include/glib-2.0/glib/glib-autocleanups.h:32:3: error: ‘ip_str’ may be used uninitialized [-Werror=maybe-uninitialized] 32 | g_free (*pp); | ^~~~~~~~~~~~ ../src/parse.c: In function ‘get_ip_family’: ../src/parse.c:1918:22: note: ‘ip_str’ was declared here 1918 | g_autofree char *ip_str; | ^~~~~~ cc1: all warnings being treated as errors -
-
The RPM build started to fail on Fedora 41: find-debuginfo: starting Extracting debug info from 4 files gdb-add-index: Failed to find a useable GDB binary
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.