New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-2122] Internal Secrets implementation - juju 3 #102

Merged

juditnovak merged 19 commits into main from DPE-2122_opensearch_charm_on_juju3_secrets

Sep 1, 2023

Contributor

juditnovak commented Jul 10, 2023 •

edited

Loading

Issue

Juju 3 secrets to be integrated to Openseach Charm

Solution

NOTE: For this purpose we agreed to implement a partial Juju3 pipeline on top of the exising Juju2 one, in order to preserve CI runtimes

juditnovak force-pushed the DPE-2122_opensearch_charm_on_juju3_secrets branch 3 times, most recently from a135ddb to 330a52a Compare

July 11, 2023 08:23

github-actions bot added the Libraries: Out of sync label

juditnovak commented

View reviewed changes

lib/charms/opensearch/v0/constants_secrets.py Outdated Show resolved Hide resolved

juditnovak force-pushed the DPE-2122_opensearch_charm_on_juju3_secrets branch 7 times, most recently from ce208c1 to 69378c0 Compare

July 11, 2023 23:09

Mehdi-Bendriss reviewed

View reviewed changes

lib/charms/opensearch/v0/opensearch_base_charm.py Outdated Show resolved Hide resolved

lib/charms/opensearch/v0/helper_secrets.py Outdated Show resolved Hide resolved

lib/charms/opensearch/v0/helper_secrets.py Outdated Show resolved Hide resolved

lib/charms/opensearch/v0/helper_secrets.py Outdated Show resolved Hide resolved

lib/charms/opensearch/v0/helper_secrets.py Outdated Show resolved Hide resolved

lib/charms/opensearch/v0/constants_secrets.py Outdated Show resolved Hide resolved

juditnovak removed the Libraries: Out of sync label

juditnovak force-pushed the DPE-2122_opensearch_charm_on_juju3_secrets branch from 14bad6a to 2c756c8 Compare

July 12, 2023 13:30

github-actions bot added the Libraries: Out of sync label

juditnovak changed the title ~~[DPE-2122] Opensearch Charm on juju3 secrets~~ [WIP -- IGNORE][DPE-2122] Opensearch Charm on juju3 secrets

juditnovak commented

View reviewed changes

lib/charms/opensearch/v0/opensearch_base_charm.py Outdated Show resolved Hide resolved

juditnovak commented

View reviewed changes

lib/charms/opensearch/v0/opensearch_data.py Outdated Show resolved Hide resolved

juditnovak commented

View reviewed changes

lib/charms/opensearch/v0/opensearch_data.py Outdated Show resolved Hide resolved

juditnovak commented

View reviewed changes

lib/charms/opensearch/v0/opensearch_data.py Outdated Show resolved Hide resolved

juditnovak commented

View reviewed changes

lib/charms/opensearch/v0/opensearch_base_charm.py Outdated Show resolved Hide resolved

juditnovak commented

View reviewed changes

lib/charms/opensearch/v0/opensearch_data.py Outdated Show resolved Hide resolved

juditnovak force-pushed the DPE-2122_opensearch_charm_on_juju3_secrets branch 3 times, most recently from 7e029d2 to 760e4b0 Compare

August 3, 2023 00:36

juditnovak commented

View reviewed changes

.github/workflows/integration-limited-juju3.yaml Outdated Show resolved Hide resolved

juditnovak commented

View reviewed changes

tests/unit/lib/test_opensearch_data.py Outdated Show resolved Hide resolved

juditnovak commented

View reviewed changes

tests/unit/lib/test_opensearch_data.py Outdated Show resolved Hide resolved

juditnovak force-pushed the DPE-2122_opensearch_charm_on_juju3_secrets branch from 760e4b0 to cb2f6d0 Compare

August 3, 2023 00:57

Mehdi-Bendriss approved these changes

View reviewed changes

Mehdi-Bendriss changed the title ~~[DPE-2122] Opensearch Charm on juju3 secrets~~ [DPE-2122] Internal Secrets implementation - juju 3

marceloneppel approved these changes

View reviewed changes

juditnovak force-pushed the DPE-1817_juju3_pipeline branch 3 times, most recently from 499ed02 to 5b74ba4 Compare

August 31, 2023 13:47

Base automatically changed from DPE-1817_juju3_pipeline to main

August 31, 2023 21:25

juditnovak added 18 commits

September 1, 2023 00:33


          Adding pytest-mock and parametrize

d8e4bfc


          Modifications on constanst and exceptions

9e5d529


          Secrets implementation in opensearch_internal_data module

b708c25


          Refactored old, and added new tests

ef1c4bc


          Additional changes on opensearch_tls, opensearch_base_charm and the c…

eaf51b0

…harm itself


          Unittest modification needed for ca-chain (list)

9a13f9e


          Test changes since two-letter secret key (like ca) is not allowed

af27b4b


          Secrets always accessed by .get() method, for enhanced safety and com…

79ce860

…patibility


          Removing all() method from [Relation]DataStore


          Removing all() method references (only impact in tests)

6ab82da


          Adjustments on label functions + tests

85f7ba6


          Turning charm.store_tls_resources() into a public function

4a81a72


          Secrests as a separate 'sub-charm'

c91e25e


          Secret constants re-organized, flattened

18f1487


          Saving secret ID in peer relation data

d1000a2


          Moving Secrets functionality to OpensSearchSecrets

df0dd5e


          Moving back Scope to where it was originally (opensearch_internal_data)

f6a8a8e


          Changes responding to requests on the PR

04fc6d7

juditnovak force-pushed the DPE-2122_opensearch_charm_on_juju3_secrets branch from f55ad2e to 505dafc Compare

August 31, 2023 22:34


          Juju version detection independent from libjuju installed

b6d8aa0

juditnovak force-pushed the DPE-2122_opensearch_charm_on_juju3_secrets branch from 505dafc to b6d8aa0 Compare

August 31, 2023 22:35

juditnovak merged commit cb3611a into main

23 checks passed

juditnovak deleted the DPE-2122_opensearch_charm_on_juju3_secrets branch

September 1, 2023 08:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Libraries: Out of sync