[DPE-2935] Integrating Prometheus Exporter #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juditnovak
force-pushed
the
DPE-2935_intrgrating_prometheus_exporter
branch
from
b24661b
to
3f9254e
Compare
juditnovak
changed the base branch from
DPE-3019-add-url-plugin-and-prometheus
to
main
juditnovak
force-pushed
the
DPE-2935_intrgrating_prometheus_exporter
branch
from
0e6819c
to
df7afa0
Compare
juditnovak
changed the title
juditnovak
force-pushed
the
DPE-2935_intrgrating_prometheus_exporter
branch
4 times, most recently
from
3362bd7
to
b90884a
Compare
juditnovak
force-pushed
the
DPE-2935_intrgrating_prometheus_exporter
branch
5 times, most recently
from
46e2ca2
to
f05e7a7
Compare
juditnovak
commented
Nov 29, 2023
juditnovak
commented
Nov 29, 2023
|
Hi @juditnovak, I have found a way to manage the removal of a given plugin, without neither removing the method What happens now is that we defer the relation-broken event until there is no more relations between opensearch and grafana-agent. I see that as a valid solution for the relation-broken issue. |
|
@phvalguima Sure, changes from your diff applied as a separate commit |
juditnovak
force-pushed
the
DPE-2935_intrgrating_prometheus_exporter
branch
3 times, most recently
from
41ad4d0
to
4f04de2
Compare
* Charm config * OpenSearch version With these options, it is possible to have an external URL passed as configuration parameter to the charm. The plugin class loads that config, resolves the version and returns a custom install_path. Original functionality persists: if the charm does not implement new install_path property, then it returns plugin name.
juditnovak
force-pushed
the
DPE-2935_intrgrating_prometheus_exporter
branch
6 times, most recently
from
04928a5
to
df083e9
Compare
delgod
requested changes
Dec 4, 2023
juditnovak
force-pushed
the
DPE-2935_intrgrating_prometheus_exporter
branch
2 times, most recently
from
be76844
to
2ed9511
Compare
juditnovak
force-pushed
the
DPE-2935_intrgrating_prometheus_exporter
branch
from
2ed9511
to
16ee479
Compare
delgod
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.