Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where the ring buffer might deadlock because rwlock and iterator mutex are acquired in a different order.
Fixes: #508
Notes:
rb.Write
isn't adjusted because the rwlock and iterator mutex are acquired at different times.close
function, an internalpositions
function is created for the same reason.TestDeadlock
test case anyway.signalIterators
,releaseIterators
andremoveIterator
are adjusted (although technical onlyreleaseIterators
needed to be ) because they share a common naming pattern so it's nicer to share a common implementation pattern as well: all internal functions don't operate locks.Benchmark test, manual test to reproduce the 3-way deadlock issue, and race test are all done and passed.