Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sync_docs.yaml #588

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Update sync_docs.yaml #588

merged 1 commit into from
Aug 20, 2024

Conversation

a-velasco
Copy link
Contributor

A new sync_docs.yaml workflow was released in data-platform-workflows v19.2.0. It overwrites the old experimental _sync_docs.yaml workflow and releases it to the public interface.

This PR:

  • Corrects the filename to match the new syntax without the experimental _ prefix.
  • Removes the now unnecessary Discourse API credentials
  • Adds automatic reviewers

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.89%. Comparing base (64b94d2) to head (a008e81).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #588   +/-   ##
=======================================
  Coverage   70.89%   70.89%           
=======================================
  Files          12       12           
  Lines        3030     3030           
  Branches      536      536           
=======================================
  Hits         2148     2148           
  Misses        768      768           
  Partials      114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-velasco a-velasco merged commit 3316ac8 into main Aug 20, 2024
10 checks passed
@a-velasco a-velasco deleted the update-sync-docs branch August 20, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants