Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move useLocation within useNotify hook to cater for latest react-router-dom limitations #1017

Merged
merged 1 commit into from
Jan 19, 2024
Merged

fix: move useLocation within useNotify hook to cater for latest react-router-dom limitations #1017

merged 1 commit into from
Jan 19, 2024

Conversation

mas-who
Copy link
Contributor

@mas-who mas-who commented Jan 18, 2024

Done

  • moved useLocation call from the NotificationProvider component into the useNotify hook. This circumvents the issue where react router no longer accepts usage of useLocation outside of the Router context.

QA

  • I checked this by copying the change over to the lxd-ui repo, then QA'd there.

@webteam-app
Copy link

Demo starting at https://react-components-1017.demos.haus

edlerd
edlerd approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this fix for the react-router update.

@mas-who mas-who merged commit 6baf889 into canonical:main Jan 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

Assignees
No one assigned
Labels
Review: Code needed Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mas-who @webteam-app @edlerd