Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove nanoid #1050

Merged
merged 1 commit into from
Mar 4, 2024
Merged

refactor: remove nanoid #1050

merged 1 commit into from
Mar 4, 2024

Conversation

huwshimi
Copy link
Collaborator

@huwshimi huwshimi commented Mar 4, 2024

Done

  • Deprecate custom useId hook and use useId provided by React 18.

@webteam-app
Copy link

Demo starting at https://react-components-1050.demos.haus

vladimir-cucu
vladimir-cucu approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@vladimir-cucu vladimir-cucu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

src/hooks/useId.ts Show resolved Hide resolved
@huwshimi huwshimi merged commit c699e32 into canonical:main Mar 4, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

🎉 This PR is included in version 0.50.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bartaz bartaz mentioned this pull request Jul 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimir-cucu vladimir-cucu vladimir-cucu approved these changes

Assignees
No one assigned
Labels
Maintenance 🔨 released Review: Code +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huwshimi @webteam-app @vladimir-cucu