feat: allow loading and disable state for confirm button in ConfirmationModal #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
mas-who
added
Review: Code needed
Review: Percy needed
and removed
Review: Percy needed
labels
edlerd
approved these changes
Apr 22, 2024
Comment on lines
37
to
41
| confirmButtonLoading?: boolean; | ||
| /** | ||
| * Disable the confirm button. | ||
| */ | ||
| confirmButtonDisabled?: boolean; |
There was a problem hiding this comment.
Maybe both can be loading and disabled to stay in line with how the action button component calls them? Or do you think those will be too ambiguous?
There was a problem hiding this comment.
Yeah I think it might be a little ambiguous since there are two buttons?
lorumic
reviewed
Apr 22, 2024
…ionModal Signed-off-by: Mason Hu <[email protected]>
mas-who
force-pushed
the
confirm-modal-loading-and-disable
branch
from
90434a2 to
bad3afa
Compare
mas-who
added
Review: Code +1
Review: Percy +1
and removed
Review: Code needed
Review: Percy needed
labels
|
🎉 This PR is included in version 0.52.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done