Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: forwardRef from SideNavigationLink component #1118

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

aaryanporwal
Copy link
Contributor

Done

  • use forwardRef in SideNavigationLink Component

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Steps for QA.

Percy steps

  • List any expected visual change in Percy, or write something like "No visual changes expected" if none is expected.

Fixes

Fixes: # .

@webteam-app
Copy link

@abhigyanghosh30 abhigyanghosh30 merged commit 9546e5d into canonical:main Aug 23, 2024
10 of 11 checks passed
Copy link

🎉 This PR is included in version 1.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@huwshimi huwshimi mentioned this pull request Sep 2, 2024
@huwshimi
Copy link
Collaborator

huwshimi commented Sep 2, 2024

This change looks like it is causing an issue as it's trying to extract the ref from the props object: #1122.

@aaryanporwal
Copy link
Contributor Author

Thanks @huwshimi for reporting this. I've pushed a new fix PR #1123 can you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants